I don't think social security will disappear, but I think the benefits will be scaled back and the retirement age increased again at some point. It gets ridiculous at some point, how old should you be to collect social security, 90?? If they make the retirement age high enough, they won't have to pay out any benefits!
I'd be a lot happier if I was allowed to invest at least some of the money they withhold from my paychecks in investments.
I've been investing since I was in college, I'm not Warren Buffet, but I have accumulated a nice nestegg. I think the best advice is to diversify, don't put all your eggs in one basket. I have stocks, stock mutual funds, bond mutual funds, savings accounts, even at the worst of times, not everything I have is dropping.
My other major piece of advice is not to chase the hottest investment of the day. In fact, more often than not, contrarians do best, buying when no one else is buying.
Over and over again I've seen it, in the late 90's everyone was buying tech stocks, they were going through the roof, but then they crashed. Then people were jumping into real estate, but that crashed. Now gold is hot. Everything seems to point to it continuing to rise. But I keep thinking I've seen this movie before, many times.
So we'll just have to see what happens.
For the last 10 years, dividend paying stocks and foreign bond and mutual funds have done best for me. I like large older companies that pay a nice dividend. It's like you are getting paid to own the stock while you wait for it to go up. CD's are only paying 1% or so, but there are tons of good solid companies out there paying 3%, 4%, even 6% yields, companies like Johnson and Johnson, Kimberly Clark, Coca Cola, AT&T, Verizon. Even Microsoft is paying over 2% with its dividend.
If you want to get a little riskier, there are stocks paying even higher dividends. Real Estate investment Trusts often pay over 10%. I've got one that is paying over 15%!
Emerging markets have a lot of potential, but again, don't put all your eggs in one basket, but having 5-15% of your portfolio in emerging market mutual funds and foreign stock mutual funds very likely will pay off in the long run.
Last piece of advice I can give is don't panic when things crash, they more often than not come back after awhile. Too many people follow the trends, buying near the peak and then selling at the bottom. Don't follow the herd!